Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new agents tasks and customizing environment guide #256

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Jul 27, 2023

Description

Motivation and Context

An issue raised in discussion about environment customizing. We update the answer in README as well.

Safety-Gymnasium has supported new agents Doggo and Racecar and we add them in the register as well. The performance curves and tables would be coming soon in future pull requests.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj added documentation Improvements or additions to documentation feature Something related to new features environment Something related to the RL environment labels Jul 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #256 (d7a78a7) into main (19f7fc7) will not change coverage.
The diff coverage is n/a.

❗ Current head d7a78a7 differs from pull request most recent head 854c71a. Consider uploading reports for the commit 854c71a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         138      138           
  Lines        6990     6990           
=======================================
  Hits         6781     6781           
  Misses        209      209           
Files Changed Coverage Δ
omnisafe/envs/safety_gymnasium_env.py 97.96% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit 7fcfe78 into PKU-Alignment:main Aug 1, 2023
4 checks passed
@Gaiejj Gaiejj mentioned this pull request Aug 4, 2023
11 tasks
@Gaiejj Gaiejj deleted the dev-readme branch August 10, 2023 07:13
@Gaiejj Gaiejj mentioned this pull request Aug 10, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation environment Something related to the RL environment feature Something related to new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants