Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gymnasium style reset API #266

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Aug 10, 2023

Description

The reset functions in wrapper, env and adapter are not suitable for Gymnasium style API, which miss an option argument. This pull request add this interface and would not affect the previous usage and performance.

Motivation and Context

It solves issue #265

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj added enhancement New feature or request environment Something related to the RL environment labels Aug 10, 2023
@Gaiejj Gaiejj marked this pull request as ready for review August 10, 2023 10:42
Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit 80c2c23 into PKU-Alignment:main Aug 12, 2023
4 checks passed
@Gaiejj Gaiejj deleted the dev-env branch September 5, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request environment Something related to the RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants