feat(off-policy): fix final_obsevation setting and support evaluation times configuation #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Previously the off-policy algorithms must evaluate once per episode, This pull request would set the times of evaluation as a configuration. If you do not want to evaluate during training process, please set it to 0.
We process the
final_observation
to address the issue of the end of trajectory. However, not all environments have the keyfinal_observation
in theinfo
ofstep
function. So we fix it by a simpleif-else
judgement.I have raised an issue to propose this change (required for new features and bug fixes)
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)