Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(off-policy): fix final_obsevation setting and support evaluation times configuation #260

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Jul 31, 2023

Description

Motivation and Context

  • Previously the off-policy algorithms must evaluate once per episode, This pull request would set the times of evaluation as a configuration. If you do not want to evaluate during training process, please set it to 0.

  • We process the final_observation to address the issue of the end of trajectory. However, not all environments have the key final_observation in the info of step function. So we fix it by a simple if-else judgement.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj added bug Something isn't working enhancement New feature or request algorithm Some issues about algorithm labels Jul 31, 2023
@Gaiejj Gaiejj changed the title Dev meta feat(off-policy): fix final_obsevation setting and support evaluation times configuation Jul 31, 2023
Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj enabled auto-merge (squash) August 1, 2023 12:23
@Gaiejj Gaiejj disabled auto-merge August 1, 2023 12:25
@Gaiejj Gaiejj merged commit 9e76d28 into PKU-Alignment:main Aug 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Some issues about algorithm bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants