Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update pre-commit.yaml and fix ruff #261

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Aug 2, 2023

Description

  • Update code style to meet the new requirement of ruff.
  • Update pre-commit.yaml as well

Motivation and Context

ruff failed in PR #260, this PR fix it.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj added dependency Something related to package dependencies codestyle update codestyple labels Aug 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #261 (20aa2d0) into main (9e76d28) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 20aa2d0 differs from pull request most recent head f3cbb42. Consider uploading reports for the commit f3cbb42 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   97.00%   96.97%   -0.03%     
==========================================
  Files         138      138              
  Lines        6991     6991              
==========================================
- Hits         6781     6779       -2     
- Misses        210      212       +2     
Files Changed Coverage Δ
omnisafe/algorithms/on_policy/second_order/pcpo.py 100.00% <ø> (ø)
omnisafe/algorithms/model_based/base/loop.py 97.87% <100.00%> (ø)
omnisafe/algorithms/model_based/base/pets.py 100.00% <100.00%> (ø)
omnisafe/utils/tools.py 98.43% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Gaiejj Gaiejj merged commit 8702d79 into PKU-Alignment:main Aug 4, 2023
4 checks passed
@Gaiejj Gaiejj deleted the dev-ruff branch September 5, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codestyle update codestyple dependency Something related to package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants