Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): 新增以 shell 的方式进入容器的功能 #1180

Merged
merged 21 commits into from
Apr 11, 2024
Merged

Conversation

Miracle575
Copy link
Contributor

@Miracle575 Miracle575 commented Mar 27, 2024

ai 新增进入训练中的作业的容器并执行 shell 操作的功能。该功能依赖于 k8s 的 api server,所以需要一份 kubectl config 配置文件。
image

image

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: a611fc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-11 12:51 UTC

@Miracle575
Copy link
Contributor Author

功能还比较复杂,申请测试介入

@Miracle575 Miracle575 marked this pull request as ready for review March 29, 2024 03:45
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Mar 29, 2024
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把这个功能需要的接口放在现在已经有的scow-ai-test-job分支中,等AI发布后直接合并这个scow-ai-test-job的PR

docs/docs/deploy/config/ai/intro.md Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Mar 29, 2024
@Miracle575 Miracle575 requested a review from ddadaal April 7, 2024 08:50
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Apr 7, 2024
docs/docs/deploy/config/ai/intro.md Outdated Show resolved Hide resolved
docs/docs/deploy/config/ai/intro.md Outdated Show resolved Hide resolved
libs/config/src/cluster.ts Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Apr 8, 2024
@Miracle575 Miracle575 requested a review from ddadaal April 9, 2024 02:29
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Apr 9, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Apr 9, 2024
@lyl-available
Copy link
Contributor

1、进入容器,刷新并连接只能点一次
2、进入容器有时会出现无法连接的情况

@pkuhpc-review-bot pkuhpc-review-bot bot added E2E-ReviewRequested E2E Test requested and removed ReadyForMerge Ready for merge labels Apr 10, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added E2E-Approved E2E Test approved ReadyForMerge Ready for merge and removed E2E-ReviewRequested E2E Test requested labels Apr 11, 2024
@ddadaal ddadaal merged commit 93e1133 into master Apr 11, 2024
9 checks passed
@ddadaal ddadaal deleted the feat-ai-shell branch April 11, 2024 12:48
ddadaal added a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved E2E-Approved E2E Test approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants