Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): ai 增加vnc, shell 到容器, ai提交作业优化 #1202

Merged
merged 63 commits into from
Apr 23, 2024

Conversation

ZihanChen821
Copy link
Contributor

@ZihanChen821 ZihanChen821 commented Apr 7, 2024

ai 提交作业优化

  1. 支持多个挂载点
  2. 镜像支持手动输入
  3. 已分享的镜像,数据集,以及模型,选取私有时,取privatePath而不是分享后的路径
  4. 将提交作业时ai相关的参数都放入extra_options里

ai 新增以shell 的方式进入容器的功能

ai 新增进入训练中的作业的容器并执行 shell 操作的功能。该功能依赖于 k8s 的 api server,所以需要一份 kubectl config 配置文件。
image

image

ai 增加 vnc

Ai模块新增vnc应用

@ZihanChen821 ZihanChen821 marked this pull request as ready for review April 11, 2024 08:47
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Apr 11, 2024
@ddadaal
Copy link
Member

ddadaal commented Apr 11, 2024

这个和 #1177 是不是一样的?这个更新我就先看这个了

@ZihanChen821
Copy link
Contributor Author

这个和 #1177 是不是一样的?这个更新我就先看这个了

是的 这个是三个pr的融合

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Apr 11, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added E2E-ReviewRequested E2E Test requested and removed ReadyForMerge Ready for merge labels Apr 11, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added E2E-Approved E2E Test approved ReadyForMerge Ready for merge and removed E2E-ReviewRequested E2E Test requested labels Apr 23, 2024
@ddadaal ddadaal merged commit e312efb into master Apr 23, 2024
9 checks passed
@ddadaal ddadaal deleted the test-ai-vnc-shell branch April 23, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved E2E-Approved E2E Test approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants