Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): 门户系统部分UI更新 #1277

Merged
merged 27 commits into from
Jun 19, 2024
Merged

Conversation

usaveh
Copy link
Contributor

@usaveh usaveh commented May 31, 2024

做了什么:
更改了portal门户部分UI的样式:
修改后
image

image

修改前:
image

image

图标颜色和主题色相统一:

image

Copy link

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: 87b6a9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@scow/portal-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/portal-server Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label May 31, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal May 31, 2024 07:24
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 黑暗模式下用户信息部分颜色看不清,能否也改回红色?

image

  1. 到MIS出现了两个图标,只保留左边那个就行
    image

  2. 首页快速链接的那几个图标的主题色能不能和系统的主题色统一?

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels May 31, 2024
@usaveh
Copy link
Contributor Author

usaveh commented Jun 3, 2024

  1. 黑暗模式下用户信息部分颜色看不清,能否也改回红色?

image

  1. 到MIS出现了两个图标,只保留左边那个就行
    image
  2. 首页快速链接的那几个图标的主题色能不能和系统的主题色统一?

1:okk
2,3:目前设计稿是这样的,和若淼老师确认过。

@vanstriker
Copy link
Member

vanstriker commented Jun 3, 2024

1、感觉dark模式是不是不用纯黑背景比较好,已经联系设计在看看这部分;
2、我感觉也可以去掉右边那个;
3、主题色这个是指什么,咱们自己设计的图标应该是和主题色一致的吧

@usaveh usaveh added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Jun 4, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal June 4, 2024 03:11
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCOW是可以改主题色的,图中的主题色就是默认的红色 :https://pkuhpc.github.io/SCOW/docs/deploy/config/customization/webui#%E8%87%AA%E5%AE%9A%E4%B9%89%E4%B8%BB%E9%A2%98%E8%89%B2%E5%92%8Cfooter%E6%96%87%E6%9C%AC

理论上来说,通过修改svg的部分区域的颜色可以做到让SVG的颜色和主题色相统一,可以试试看这样做起来是不是比较复杂。如果比较复杂,或者效果不好,需要重新设计图标,使得图标和主题色无关,也就是图标在任何主题色都不会显得违和

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Jun 12, 2024
@usaveh usaveh added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Jun 19, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal June 19, 2024 09:18
@usaveh
Copy link
Contributor Author

usaveh commented Jun 19, 2024

SCOW是可以改主题色的,图中的主题色就是默认的红色 :https://pkuhpc.github.io/SCOW/docs/deploy/config/customization/webui#%E8%87%AA%E5%AE%9A%E4%B9%89%E4%B8%BB%E9%A2%98%E8%89%B2%E5%92%8Cfooter%E6%96%87%E6%9C%AC

理论上来说,通过修改svg的部分区域的颜色可以做到让SVG的颜色和主题色相统一,可以试试看这样做起来是不是比较复杂。如果比较复杂,或者效果不好,需要重新设计图标,使得图标和主题色无关,也就是图标在任何主题色都不会显得违和

已针对上述问题修改为主题色

Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我反对现在这个黑暗模式的背景。其他几乎所有网站和应用(最直接的例子就是现在正在用的github)的黑暗模式都是和原来的黑暗模式类似的,以灰黑色为底色,看着很和谐,为什么要改成现在这个颜色?另外,现在这个背景颜色甚至和默认主题色都不匹配,header的颜色看着甚至会刺眼

image

同时完善了一些UI

  • 快捷方式右上角的按钮使用antd的按钮
  • 右上角的mis图标也会随着主题色更新

dev/vagrant/config/auth.yml Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Jun 19, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ChangeRequested labels Jun 19, 2024
@ddadaal ddadaal merged commit f21f3e0 into master Jun 19, 2024
10 checks passed
@ddadaal ddadaal deleted the feat-dashboard-UI-update branch June 19, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants