Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 增加获取交互式应用和作业模版JSON.parse错误的处理 #1417

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

OYX-1
Copy link
Contributor

@OYX-1 OYX-1 commented Aug 29, 2024

之前的错误:在获取交互式应用和作业模版页,遇到不是json格式的字符串时会报一下错误

image

改动

1. try catch JSON.parse:在获取交互式应用列表时遇到非json格式的字符串,直接跳过;在获取作业模版时遇到非json格式的字符串,返回默认数据;

2. 当作业模版是无效的占位数据时,无法使用和重命名模版

image

Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: bec5b4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@scow/portal-server Patch
@scow/portal-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Aug 29, 2024
apps/portal-server/src/clusterops/job.ts Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Aug 29, 2024
@OYX-1 OYX-1 requested a review from ddadaal August 30, 2024 02:06
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Aug 30, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Aug 30, 2024
@ddadaal ddadaal merged commit a47aa76 into master Aug 30, 2024
9 checks passed
@ddadaal ddadaal deleted the fix-json-parse branch August 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants