Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth)!: 拆分getUser为独立的认证系统能力 #314

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

ddadaal
Copy link
Member

@ddadaal ddadaal commented Nov 27, 2022

经过进一步考虑,发现getUser应该是一个独立的认证系统能力。有的认证系统不支持创建用户,但是支持查询用户是否存在,比如SSH。有的认证系统支持创建用户,但是不支持查询用户是否存在,比如一些机构的内部认证系统,内部认证系统基本不会给接入者随便查询任意用户的能力。所以getUser应该不是和创建用户的绑定的接口,而是一个独立的能力。

@codecov-commenter
Copy link

Codecov Report

Base: 64.38% // Head: 64.60% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (f0fdc18) compared to base (9315a08).
Patch coverage: 75.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   64.38%   64.60%   +0.22%     
==========================================
  Files          99      100       +1     
  Lines        2802     2811       +9     
  Branches      349      348       -1     
==========================================
+ Hits         1804     1816      +12     
+ Misses        953      950       -3     
  Partials       45       45              
Impacted Files Coverage Δ
apps/auth/src/routes/capabilities.ts 75.00% <ø> (ø)
apps/auth/src/routes/getUser.ts 84.61% <50.00%> (ø)
apps/auth/src/auth/ldap/createUser.ts 67.85% <67.85%> (ø)
libs/auth/src/getUser.ts 85.71% <85.71%> (ø)
apps/auth/src/auth/ldap/index.ts 46.87% <100.00%> (-9.92%) ⬇️
apps/auth/src/auth/ssh/index.ts 67.85% <100.00%> (+8.76%) ⬆️
apps/auth/src/routes/createUser.ts 83.33% <100.00%> (ø)
libs/auth/src/createUser.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ddadaal ddadaal merged commit 911c5f0 into master Nov 27, 2022
@ddadaal ddadaal deleted the update-auth-api branch November 27, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants