Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added renovate bot icon #1139

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Added renovate bot icon #1139

merged 4 commits into from
Jul 12, 2021

Conversation

shivapoudel
Copy link
Contributor

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the icon be resized to 20px in a 24px grid?

@shivapoudel
Copy link
Contributor Author

@4086606 Resized :)

@PKief PKief self-requested a review July 6, 2021 11:06
@shivapoudel
Copy link
Contributor Author

shivapoudel commented Jul 6, 2021

@PKief Please have a look at this thread if you can beautify the icon like the brand. @rarkins had provided the brand logo but still, we need some refactor for our file icon use case.

renovatebot/renovate#10721

@PKief
Copy link
Member

PKief commented Jul 7, 2021

@shivapoudel The icon looks quite nice, but in my opinion it's a little bit hard to recognize in the file explorer. I think it would be better if you could try to use the format-paint icon with the same color as you've right now. It should look pretty good. Nobody forces us to use the exact logo of the brand if the icon could by a simplified version of it.

Maybe you can also rotate it to the same position as the brand icon. Would be worth trying it ;)

@shivapoudel
Copy link
Contributor Author

@PKief sorry to say but I am not a big expert in using the Figma tool or other SVG editor so will not be able to re-fine the SVG. I have just copied the SVG icons available in the file icons repo and recreated them, later I have just maintained the grid.

@4086606 If you wanna help with this icon, feel free to refine the icon according to @PKief suggestions.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the file icon so that it looks like this now:

image

In my opinion it now has a clear shape and a nice contrast. I reused the color of the previous icon. Thanks for your contribution, it's an appreciated improvement!

@PKief PKief merged commit 18b0b4b into material-extensions:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] Support for Renovate Bot
2 participants