feat: added icon for the lighthouse config files #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PKief
requested changes
Aug 25, 2021
There was a problem hiding this comment.
Thank you for the contribution! The official icon of lighthouse is not very suitable to used within this extension as it has some white areas and I think the icon is too complex to be used as file icon.
I'd recommend using the lighthouse icon of the Material Design Icons library. Probably you could give it a color of the Material Color Palette. I think it will be a great fit then.
|
I've updated it with the Material Design Icons library as you suggested: Alternatives:
WDYT? |
|
I'd prefer if it would look like this:
|
PKief
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an icon for the Lighthouse config files