Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart generated files icon #1465

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Dart generated files icon #1465

merged 3 commits into from
Apr 26, 2022

Conversation

lifeapps-42
Copy link
Contributor

Flutter developer widely use generated dart files. (*freezed.dart and *g.dart)

So, it should be very useful if these files had different icon.

Screenshot 2022-04-10 at 19 11 56

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lifeapps-42 looks like a nice improvement to this extension. To get this ready for the merge we need to fix the colors of the generated icon. The pipeline is complaining about these colors:

image

Could you please take a look here? You can find the allowed colors here:
https://pkief.github.io/material-color-converter/

@lifeapps-42
Copy link
Contributor Author

Thx, I'll check this out

@lifeapps-42
Copy link
Contributor Author

@PKief It should be fine now :)

@lifeapps-42 lifeapps-42 requested a review from PKief April 23, 2022 10:22
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly adjusted the colors but it looks amazing now, thank you for your contribution :)

@PKief PKief merged commit d905563 into material-extensions:main Apr 26, 2022
@MisterLight MisterLight mentioned this pull request Jul 6, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants