Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vala icon #466

Merged
merged 64 commits into from Jun 3, 2020
Merged

Add vala icon #466

merged 64 commits into from Jun 3, 2020

Conversation

drom98
Copy link
Contributor

@drom98 drom98 commented Jun 8, 2019

Resolves #309

@PKief PKief self-requested a review June 9, 2019 17:13
@naipotato
Copy link

Waiting for this icon too

@saisuryakat
Copy link
Contributor

@PKief May I know the reason for not merging this pull-request ? Is it the merge conflict ?

@saisuryakat
Copy link
Contributor

saisuryakat commented May 1, 2020

@PKief Could you please enable this vala icon too....looking for this specific icon from long, let me know if there's anything I could do....

@drom98
Copy link
Contributor Author

drom98 commented May 2, 2020

I don't know why wasn't this merged.

PKief and others added 28 commits May 9, 2020 08:38
add jest icons for jest.config.(m|c)js
rc file type is used as nodenv local env config file
added .node-version filetype to nodejs association
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I make the color slightly lighter and reduced the size a little bit so that it looks like this now:

vala file icon

It will be part of the next update!

@PKief PKief merged commit 84e35b3 into PKief:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] Vala icon
10 participants