-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test wgssomatic #100
Unit test wgssomatic #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Failed for group 60ae2fda4c6509d1b8d523d9. Bioinformatics Tools:
WGSGermlineGATK:
Small Bioinformatics Workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Failed for group 60ae503d558684e4cf8ed0e7. Bioinformatics Tools:
WGSGermlineGATK:
Small Bioinformatics Workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Failed for group 60ae404c32cc47d90c3f7c01. Bioinformatics Tools:
WGSGermlineGATK:
Small Bioinformatics Workflow:
|
Test Succeeded for group 60ae52037eeab92ee27259c3. Bioinformatics Tools:
WGSGermlineGATK:
Small Bioinformatics Workflow:
|
Hi @junyk and @xinzhel97 - some of the test_data files are included as part of this PR. Just checking, if they are intended to be checked in to this repo? Thanks |
@rlupat @xinzhel97 i think we prefer to upload them to Nectar. Including expected files. Especially if they are big. |
It's only a temporary solution because the files are not up on Nectar yet. It's also what we did last time. Once the files are uploaded, they can be removed and I'll also change the file paths in unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a note here so we don't forget. As per discussion on Wednesday, we want to move all the local test files to Nectar. So, we will need to update the file path in this PR to nectar URL. Thanks!
@junyk I just updated the file paths and deleted the local testing files. Hope that helps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Succeeded for group 60c082b0706911e3ee2ba5c6. Bioinformatics Tools:
WGSGermlineGATK:
Small Bioinformatics Workflow:
|
Add unit tests to tools involved in WGSSomaticGATK pipeline, except the ones that were already covered in WGSGermlineGATK pipeline