Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test wgssomatic #100

Merged
merged 6 commits into from
Jun 16, 2021

Conversation

xinzhel97
Copy link
Contributor

Add unit tests to tools involved in WGSSomaticGATK pipeline, except the ones that were already covered in WGSGermlineGATK pipeline

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janis-bot
Copy link

Test Failed for group 60ae2fda4c6509d1b8d523d9.

Bioinformatics Tools:

  • ParseFastqcAdaptors.None (Nectar - cromwell): Test Succeeded
  • ParseFastqcAdaptors.None (Spartan - cromwell): Test Failed 60ae2fda4c6509d1b8d523db
  • SamToolsFlagstat.None (Nectar - cromwell): Test Succeeded
  • SamToolsFlagstat.None (Spartan - cromwell): Test Failed 60ae2fda4c6509d1b8d523dd
  • Gatk4HaplotypeCaller.None (Nectar - cromwell): Test Succeeded
  • Gatk4HaplotypeCaller.None (Spartan - cromwell): Test Failed 60ae2fda4c6509d1b8d523df
  • performanceSummary.None (Nectar - cromwell): Test Succeeded
  • performanceSummary.None (Spartan - cromwell): Test Failed 60ae2fda4c6509d1b8d523e1

WGSGermlineGATK:

  • WGSGermlineGATK.brca1 (Spartan - cromwell): Test Failed 60ae2fda4c6509d1b8d523e2

Small Bioinformatics Workflow:

  • bwaaligner.None (Nectar - cromwell): Test Succeeded
  • bwaaligner.None (Nectar - cwltool): Test Failed 60ae2fda4c6509d1b8d523e4

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janis-bot
Copy link

Test Failed for group 60ae503d558684e4cf8ed0e7.

Bioinformatics Tools:

  • ParseFastqcAdaptors.None (Nectar - cromwell): Test Failed 60ae503d558684e4cf8ed0e8
  • ParseFastqcAdaptors.None (Spartan - cromwell): Test Failed 60ae503d558684e4cf8ed0e9
  • SamToolsFlagstat.None (Nectar - cromwell): Test Failed 60ae503d558684e4cf8ed0ea
  • SamToolsFlagstat.None (Spartan - cromwell): Test Failed 60ae503d558684e4cf8ed0eb
  • Gatk4HaplotypeCaller.None (Nectar - cromwell): Test Failed 60ae503d558684e4cf8ed0ec
  • Gatk4HaplotypeCaller.None (Spartan - cromwell): Test Failed 60ae503d558684e4cf8ed0ed
  • performanceSummary.None (Nectar - cromwell): Test Failed 60ae503d558684e4cf8ed0ee
  • performanceSummary.None (Spartan - cromwell): Test Failed 60ae503d558684e4cf8ed0ef

WGSGermlineGATK:

  • WGSGermlineGATK.brca1 (Spartan - cromwell): Test Failed 60ae503d558684e4cf8ed0f0

Small Bioinformatics Workflow:

  • bwaaligner.None (Nectar - cromwell): Test Failed 60ae503d558684e4cf8ed0f1
  • bwaaligner.None (Nectar - cwltool): Test Failed 60ae503d558684e4cf8ed0f2

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janis-bot
Copy link

Test Failed for group 60ae404c32cc47d90c3f7c01.

Bioinformatics Tools:

  • ParseFastqcAdaptors.None (Nectar - cromwell): Test Succeeded
  • ParseFastqcAdaptors.None (Spartan - cromwell): Test Succeeded
  • SamToolsFlagstat.None (Nectar - cromwell): Test Succeeded
  • SamToolsFlagstat.None (Spartan - cromwell): Test Succeeded
  • Gatk4HaplotypeCaller.None (Nectar - cromwell): Test Succeeded
  • Gatk4HaplotypeCaller.None (Spartan - cromwell): Test Succeeded
  • performanceSummary.None (Nectar - cromwell): Test Succeeded
  • performanceSummary.None (Spartan - cromwell): Test Succeeded

WGSGermlineGATK:

  • WGSGermlineGATK.brca1 (Spartan - cromwell): Test Succeeded

Small Bioinformatics Workflow:

  • bwaaligner.None (Nectar - cromwell): Test Succeeded
  • bwaaligner.None (Nectar - cwltool): Test Failed 60ae404c32cc47d90c3f7c0c

@janis-bot
Copy link

Test Succeeded for group 60ae52037eeab92ee27259c3.

Bioinformatics Tools:

  • ParseFastqcAdaptors.None (Nectar - cromwell): Test Succeeded
  • ParseFastqcAdaptors.None (Spartan - cromwell): Test Succeeded
  • SamToolsFlagstat.None (Nectar - cromwell): Test Succeeded
  • SamToolsFlagstat.None (Spartan - cromwell): Test Succeeded
  • Gatk4HaplotypeCaller.None (Nectar - cromwell): Test Succeeded
  • Gatk4HaplotypeCaller.None (Spartan - cromwell): Test Succeeded
  • performanceSummary.None (Nectar - cromwell): Test Succeeded
  • performanceSummary.None (Spartan - cromwell): Test Succeeded

WGSGermlineGATK:

  • WGSGermlineGATK.brca1 (Spartan - cromwell): Test Succeeded

Small Bioinformatics Workflow:

  • bwaaligner.None (Nectar - cromwell): Test Succeeded
  • bwaaligner.None (Nectar - cwltool): Test Succeeded

@rlupat
Copy link
Member

rlupat commented May 31, 2021

Hi @junyk and @xinzhel97 - some of the test_data files are included as part of this PR. Just checking, if they are intended to be checked in to this repo?

Thanks

@junyk
Copy link
Member

junyk commented May 31, 2021

@rlupat @xinzhel97 i think we prefer to upload them to Nectar. Including expected files. Especially if they are big.

@xinzhel97
Copy link
Contributor Author

It's only a temporary solution because the files are not up on Nectar yet. It's also what we did last time. Once the files are uploaded, they can be removed and I'll also change the file paths in unit tests.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note here so we don't forget. As per discussion on Wednesday, we want to move all the local test files to Nectar. So, we will need to update the file path in this PR to nectar URL. Thanks!

@xinzhel97
Copy link
Contributor Author

@junyk I just updated the file paths and deleted the local testing files. Hope that helps

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@junyk junyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janis-bot
Copy link

Test Succeeded for group 60c082b0706911e3ee2ba5c6.

Bioinformatics Tools:

  • ParseFastqcAdaptors.None (Nectar - cromwell): Test Succeeded
  • ParseFastqcAdaptors.None (Spartan - cromwell): Test Succeeded
  • SamToolsFlagstat.None (Nectar - cromwell): Test Succeeded
  • SamToolsFlagstat.None (Spartan - cromwell): Test Succeeded
  • Gatk4HaplotypeCaller.None (Nectar - cromwell): Test Succeeded
  • Gatk4HaplotypeCaller.None (Spartan - cromwell): Test Succeeded
  • performanceSummary.None (Nectar - cromwell): Test Succeeded
  • performanceSummary.None (Spartan - cromwell): Test Succeeded

WGSGermlineGATK:

  • WGSGermlineGATK.brca1 (Nectar - cromwell): Test Succeeded

Small Bioinformatics Workflow:

  • bwaaligner.None (Nectar - cromwell): Test Succeeded
  • bwaaligner.None (Nectar - cwltool): Test Succeeded

@junyk junyk merged commit 0204dbe into PMCC-BioinformaticsCore:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants