Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s-string containing full expressions? #3279

Open
max-sixty opened this issue Aug 8, 2023 · 1 comment
Open

s-string containing full expressions? #3279

max-sixty opened this issue Aug 8, 2023 · 1 comment
Labels

Comments

@max-sixty
Copy link
Member

What's up?

Currently expressions in s-strings can only contain single columns:

from invoices
derive x = s"{foo} + 5"
SELECT
  *,
  foo + 5 AS x
FROM
  invoices

But I think it should be fine to expand this to allow arbitrary expressions:

from invoices
derive x = s"{foo - bar} + 5"  # currently fails
SELECT
  *,
  foo - bar + 5 AS x
FROM
  invoices

Any thoughts on why we shouldn't do this?

@aljazerzen
Copy link
Member

aljazerzen commented Aug 14, 2023

Any thoughts on why we shouldn't do this?

Because it's hard to implement :D

Not impossible, though. And it would be genuinely useful.

@aljazerzen aljazerzen removed the needs-discussion Undecided dilemma label Oct 24, 2023
@aljazerzen aljazerzen added compiler and removed language-design Changes to PRQL-the-language labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants