Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline comments and prql-doc #730

Open
mattdharmon opened this issue Jun 29, 2022 · 2 comments
Open

Multiline comments and prql-doc #730

mattdharmon opened this issue Jun 29, 2022 · 2 comments
Labels
compiler language-design Changes to PRQL-the-language

Comments

@mattdharmon
Copy link

Could we also use multiline comments to help document functions and also use them as headers?

/**
 * Comment doc blocks to help do header documentation and 
 * function documentation like:
 *
 * @param_name <type> documentation
 */

Also would be nifty for it to generate an HTML and/or README.md file like the DBT or Elixir doc generators.

@aljazerzen aljazerzen added language-design Changes to PRQL-the-language compiler labels Jun 29, 2022
@max-sixty
Copy link
Member

Very much agree on doc comments as good things.

I'm less persuaded by multi-line comments as separate syntax from single-line comments — is there a compelling case for them? With modern editors it's unlikely someone will have to do type 10 characters to comment out 10 lines...

I think doc comments are some way off, so I'll close this for the moment. Though if someone is keen to add them, feel free to open an issue with a proposal for how they'd be used and implemented.

Thanks for the original issue @mattdharmon

@vanillajonathan
Copy link
Collaborator

Related discussion #1759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler language-design Changes to PRQL-the-language
Projects
None yet
Development

No branches or pull requests

4 participants