Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
576 list podcasts #590
576 list podcasts #590
Changes from 17 commits
8227174
a94c3a1
9e53263
8fb1474
301ed35
cd1f8bf
d6afb3a
e662562
ecdf61d
a459e18
522234b
91c70e3
94e3e33
4239dba
7680f65
51240e5
3faa982
1152122
f61f573
7d705b1
2c8bea6
41d1cbf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need to happen in this PR, but would be nice to also accept the
?per
query param here. (Still defaulting to 10, if it's blank).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably add all these strings (lines 11 thru here) to
en.yml
. Or open another ticket to do that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do it as part of this ticket! I was already thinking about it, so might as well just get to it rather than spend the time making another ticket for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a @brandonhundt question... but what format is this? And is this something we use throughout the app?
Generally, we should define a
:short
and:long
format for dates and times (4 total), inen.yml
. Or maybe a couple more, if we really need to display dates/times differently for some reason. But they should get defined only there, instead of in the views.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a design question, but "My" may not be true - this is podcasts they can access, not some kind of implied ownership
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deferred to the design, but I can change it if you like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandonhundt any preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also get these values from the hash in the controller, instead of duplicating them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should maybe standardize these window/outer_window configs for all our views. (At some point - doesn't need to happen here).