Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Config as singular to podcast #898

Merged
merged 14 commits into from
Mar 13, 2024
Merged

Apple Config as singular to podcast #898

merged 14 commits into from
Mar 13, 2024

Conversation

kookster
Copy link
Member

@kookster kookster commented Oct 23, 2023

@kookster kookster requested a review from svevang October 25, 2023 20:23
app/models/apple/config.rb Outdated Show resolved Hide resolved
@kookster kookster changed the title Apple Config enhancements, UI Apple Config as singular to podcast Nov 14, 2023
@kookster
Copy link
Member Author

the changes to the models now only, but I'm missing adding a unique constraint in the db.

Copy link
Member

@svevang svevang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just a couple minor nitpicks on method name and unused class method

app/models/apple/config.rb Show resolved Hide resolved
app/models/apple/config.rb Show resolved Hide resolved
app/models/apple/config.rb Show resolved Hide resolved
app/models/apple/show.rb Outdated Show resolved Hide resolved
@kookster kookster merged commit 1f660a1 into main Mar 13, 2024
3 checks passed
@kookster kookster deleted the feat/apple_config_ui branch March 13, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants