Fix unarchived episodes published

app/models/apple/publisher.rb

@@ -106,20 +106,30 @@ def poll!(eps = episodes_to_sync)
       end
     end
 
-    def publish!(eps = episodes_to_sync)
+    def publish!
       show.sync!
       raise "Missing Show!" unless show.apple_id.present?
 
-      # delete or unpublished episodes
+      # Archive deleted or unpublished episodes.
+      # These episodes are no longer in the private feed.
       poll_episodes!(episodes_to_archive)
       archive!(episodes_to_archive)
-      show.reload
 
+      # Un-archive episodes that are re-published.
+      # These episodes are in the private feed.
+      # Unarchived episodes are converted to "DRAFTING" state.
       poll_episodes!(episodes_to_unarchive)
       unarchive!(episodes_to_unarchive)
-      show.reload
 
-      Rails.logger.tagged("Apple::Publisher#publish!") do
+      # Calculate the episodes_to_sync based on the current state of the private feed
+      deliver_and_publish!(episodes_to_sync)
+
+      # success
+      SyncLog.log!(feeder_id: public_feed.id, feeder_type: :feeds, external_id: show.apple_id, api_response: {success: true})
+    end
+
+    def deliver_and_publish!(eps)
+      Rails.logger.tagged("Apple::Publisher#deliver_and_publish!") do
         eps.each_slice(PUBLISH_CHUNK_LEN) do |eps|
           # Soft delete any existing delivery and delivery files
           prepare_for_delivery!(eps)
@@ -145,9 +155,6 @@ def publish!(eps = episodes_to_sync)
           raise_delivery_processing_errors(eps)
         end
       end
-
-      # success
-      SyncLog.log!(feeder_id: public_feed.id, feeder_type: :feeds, external_id: show.apple_id, api_response: {success: true})
     end
 
     def prepare_for_delivery!(eps)

test/models/apple/publisher_test.rb

@@ -237,6 +237,57 @@
           assert_equal [], apple_publisher.episodes_to_unarchive.map(&:feeder_id)
         end
       end
+
+      describe "archived episodes with media already delivered to apple" do
+        let(:apple_episode_api_response) {
+          build(:apple_episode_api_response,
+            apple_hosted_audio_state: Apple::Episode::AUDIO_ASSET_SUCCESS,
+            publishing_state: "ARCHIVED",
+            apple_episode_id: "123")
+        }
+
+        let(:apple_episode) { build(:uploaded_apple_episode, show: apple_publisher.show, feeder_episode: episode, api: apple_api) }
+
+        it "includes the unarchived episode in the episodes to sync" do
+          assert apple_episode.audio_asset_state_success?
+          assert apple_episode.archived?
+          assert apple_episode.has_delivery?
+
+          assert_equal [apple_episode.feeder_id], apple_publisher.episodes_to_unarchive.map(&:feeder_id)
+          # we can't sync archived episodes
+          assert_equal [], apple_publisher.episodes_to_sync.map(&:feeder_id)
+
+          unarchiver = ->(eps) do
+            eps.map do |ep|
+              sl = ep.apple_sync_log
+              attrs = sl.api_response
+              attrs["api_response"]["val"]["data"]["attributes"]["publishingState"] = "DRAFTING"
+              sl.update!(api_response: attrs)
+              sl
+            end
+          end
+
+          # assert that this includes our unarchived episode
+          deliver_and_publish = ->(eps) do
+            assert_equal [apple_episode.feeder_id], eps.map(&:feeder_id)
+            true
+          end
+
+          # eliminate calls to the apple api
+          apple_publisher.show.stub(:sync!, []) do
+            apple_publisher.stub(:poll_episodes!, []) do
+              # 1) episodes are unarchived
+              apple_publisher.stub(:unarchive!, unarchiver) do
+                # 2) then the unarchived episodes are passed in ready to have
+                # media uploaded and episode published)
+                apple_publisher.stub(:deliver_and_publish!, deliver_and_publish) do
+                  apple_publisher.publish!
+                end
+              end
+            end
+          end
+        end
+      end
     end
   end