Fix unarchived episodes published #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svevang
commented
Feb 28, 2024
| @@ -106,20 +106,30 @@ def poll!(eps = episodes_to_sync) | |||
| end | |||
| end | |||
|
|
|||
| def publish!(eps = episodes_to_sync) | |||
There was a problem hiding this comment.
Removing this default parameter fixes up the caching of episode state. So when we un-archive the episode, the subsequent call to episodes_to_sync then freshly filters episode state (derived from the private feed).
| poll_episodes!(episodes_to_archive) | ||
| archive!(episodes_to_archive) | ||
| show.reload |
There was a problem hiding this comment.
These calls are only needed when episodes move from apple_new? == true to apple_new? == false. Or when an episode moves in and out of a private feed (which should not be happening during a publishing flow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the case where a fully delivered episode is unpublished and then republished but left in a remote
DRAFTINGstate. In this case the defaultepisodes_to_syncparams were being calculated prior to the unarchiving of an episode. SinceARCHIVEDepisodes are not published, the main delivery routine was skipping these unarchived episodes.