Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude_tags ui to feeds #997

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Add exclude_tags ui to feeds #997

merged 1 commit into from
Apr 16, 2024

Conversation

brandonhundt
Copy link
Contributor

closes: #996

  • Adds Exclude Categories field to form_tags card on all feeds

To review:

  • Add a new keyword to an episode or two
  • Exclude that keyword from the Feed
  • Ensure the episode(s) is(are) excluded from the feed link

brandonhundt
brandonhundt commented Apr 16, 2024
View reviewed changes
app/views/feeds/_form.html.erb
<% if feed.custom? %>
<%= render "form_ad_zones", podcast: podcast, feed: feed, form: form %>
<%= render "form_tags", podcast: podcast, feed: feed, form: form %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this out of the feed.custom condition so it can appear on the default feed as well.

brandonhundt
brandonhundt commented Apr 16, 2024
View reviewed changes
app/views/feeds/_form_tags.html.erb
<div class="form-floating input-group">
<%= form.tag_select :exclude_tags, feed.exclude_tags || [], {}, data: {allow_new: true, allow_clear: true} %>
<%= form.label :exclude_tags %>
</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy lemon squeezy?

cavis
cavis approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brandonhundt brandonhundt merged commit 3166567 into main Apr 16, 2024
3 checks passed
@brandonhundt brandonhundt deleted the feat/996-exclude-tags-feeds branch April 16, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavis cavis cavis approved these changes

@kookster kookster Awaiting requested review from kookster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feed exclude_tags UI
2 participants
@brandonhundt @cavis