Add Ulog sync bytes to ulog stream #12144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Jun 3, 2019
There was a problem hiding this comment.
@thomasetter fyi (shouldn't affect you though).
2 Hz are fine for now (a bit higher would work as well), I don't want to make this a parameter.
Co-Authored-By: Beat Küng <beat-kueng@gmx.net>
This was referenced Jun 9, 2019
bkueng
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go along with PX4/pyulog#41
Describe problem solved by the proposed pull request
Send ulog sync bytes at 2Hz to recover from ulog data corruptions. If we want, we could have the rate as a param.