Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posix: add argument to change the CWD #12482

Merged
merged 1 commit into from Aug 1, 2019
Merged

Conversation

lamping7
Copy link
Member

@lamping7 lamping7 commented Jul 15, 2019

#9046

Because the paths/files generated by px4 depend on the location of the current working directory, simply changing it allows us to avoid conflicts with launching multiple instances.

Screenshot from 2019-07-15 13-07-12

launching one vehicle with mavros_posix_sitl.launch
Screenshot from 2019-07-15 12-32-06

launching three vehicles with multi_uav_mavros_sitl.launch
Screenshot from 2019-07-15 12-50-33

@lamping7 lamping7 marked this pull request as ready for review July 15, 2019 17:12
@lamping7 lamping7 requested a review from dagar July 15, 2019 17:12
@lamping7 lamping7 added the Sim: SITL software in the loop simulation label Jul 15, 2019
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, but can you improve the failure outputs?

platforms/posix/src/main.cpp Outdated Show resolved Hide resolved
platforms/posix/src/main.cpp Outdated Show resolved Hide resolved
platforms/posix/src/main.cpp Outdated Show resolved Hide resolved
platforms/posix/src/main.cpp Outdated Show resolved Hide resolved
@lamping7
Copy link
Member Author

@bkueng I made the changes you requested.

Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's see if Appveyor also passes.

@ghost
Copy link

ghost commented Jul 31, 2019

Hey @lamping7 so I've tested your changes and I don't know if it's because something I'm doing but when I push 3 different missions to the uav's via mavros they say that they received the waypoint. Now the problem is that they don't use these waypoints they only use the height I've set for the rest they just fly a square and all land on top of each other.

@lamping7
Copy link
Member Author

Can you share more info? Was one of the missions a square? I can't tell what you did there.

@ghost
Copy link

ghost commented Aug 1, 2019

Hey so the problem was that my coordinates where being rounded of so they ended up at almost the same location. I have tested it again and it's working correctly.

@dagar dagar merged commit 5d986f2 into PX4:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sim: SITL software in the loop simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants