Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commander move most orb subscriptions to uORB::Subscription #12119

Merged
merged 1 commit into from Jun 4, 2019
Merged

commander move most orb subscriptions to uORB::Subscription #12119

merged 1 commit into from Jun 4, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented May 30, 2019 •
edited by AuterionWrikeBot

Requires #12040 before merging.

@dagar dagar added this to the Release v1.10.0 milestone May 30, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 2, 2019
Closed
@dagar dagar force-pushed the pr-commander_subscription branch from db6cafe to 4de5f2e Compare June 3, 2019 21:38
@dagar dagar marked this pull request as ready for review June 3, 2019 21:38
@dagar
Copy link
Member Author

dagar commented Jun 3, 2019

Ready for review and testing.

@dagar dagar force-pushed the pr-commander_subscription branch from 4de5f2e to 8f16ac3 Compare June 3, 2019 21:43
@dagar dagar requested review from julianoes and a team June 3, 2019 21:43
@Tony3dr Tony3dr added this to Ready for testing in Test Flights Jun 3, 2019
julianoes
julianoes approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot nicer!

@jorge789
Copy link

jorge789 commented Jun 4, 2019

Tested on Pixhawk 2 Cube V3:

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

- Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.
- Notes
No issues noted, good flight in general.

Logs

https://review.px4.io/plot_app?log=bd5eb15e-df7f-449b-b098-2ffe1988a015

https://review.px4.io/plot_app?log=4ee85f3d-6458-4e40-a232-7ade181f4cb7

@dagar dagar merged commit 3faab90 into PX4:master Jun 4, 2019
Test Flights automation moved this from Ready for testing to Done Jun 4, 2019
@dagar dagar deleted the pr-commander_subscription branch June 4, 2019 22:44
@Junkim3DR
Copy link

Tested on Pixhawk 4 Mini v5

Modes Tested

  • Position Mode: Good.
  • Altitude Mode: Good.
  • Stabilized Mode: Good.
  • Mission Plan Mode (Automated): Good.
  • RTL (Return To Land): Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint then trigger RTL and see landing behavior.

Notes
No issues noted, good flight in general.

Logs

Tested on Pixhawk Pro v4

Modes Tested

  • Position Mode: Good.
  • Altitude Mode: Good.
  • Stabilized Mode: Good.
  • Mission Plan Mode (Automated): Good.
  • RTL (Return To Land): Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint then trigger RTL and see landing behavior.

Notes
No issues noted, good flight in general.

Logs
https://review.px4.io/plot_app?log=8b7e2582-148b-4972-964e-120f7703feac

@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
Admin: Cleanup (housekeeping) 🧹 Admin: Enhancement (improvement) 💡
Projects
No open projects
Test Flights
  
Done
Milestone
Release v1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagar @jorge789 @Junkim3DR @julianoes