RC action switch threshold defaults #14631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of action switches which trigger a behavior if mapped. The behavior is only triggered if the switch is flipped all the way down. So for 3-position switches (1-2-3) only at position 1.
The action switches behaved differently on manual_control_setpoint due to different thresholds. Example:
RTL switch:
switch up: manual_control_setpoint.return_switch=1 (on)
switch middle: manual_control_setpoint.return_switch=3 (off)
switch down: manual_control_setpoint.return_switch=3 (off)
kill switch:
switch up: manual_control_setpoint.return_switch=1 (on)
switch middle: manual_control_setpoint.return_switch=1 (on) -> not correct
switch down: manual_control_setpoint.return_switch=3 (off)
This PR changes the thresholds to be consistent and correct.