Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf2: decrease default GPS horizontal velocity noise #14992

Merged
merged 1 commit into from Jun 2, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented May 28, 2020

Actual value needs to be determined with testing. #14640 (comment)

Screenshot from 2020-05-28 09-03-24

@RomanBapst
Copy link
Contributor

@dagar Let's get some testing in and then decide what the "right" number is.
@mcsauder FYI

@priseborough
Copy link
Contributor

This would be safe to merge as is, but would probably not be the optimum value.

@dagar dagar changed the title [WIP] ekf2: decrease default GPS horizontal velocity noise ekf2: decrease default GPS horizontal velocity noise Jun 2, 2020
@dagar dagar marked this pull request as ready for review June 2, 2020 12:15
@dagar
Copy link
Member Author

dagar commented Jun 2, 2020

This would be safe to merge as is, but would probably not be the optimum value.

Ok let's merge it and iterate.

@dagar dagar merged commit 11585df into master Jun 2, 2020
@dagar dagar added this to Done in Release 1.11 Blockers via automation Jun 2, 2020
@dagar dagar deleted the pr-ekf2_gps_v_noise_default branch June 2, 2020 12:18
@priseborough
Copy link
Contributor

priseborough commented Jun 4, 2020

I flew with a value of 0.3 today

https://logs.px4.io/plot_app?log=e4b3b1f8-e1a8-400e-a90a-b36b48f0c59a
https://logs.px4.io/plot_app?log=13362bfa-eac2-4fa9-a066-ab0adbad5959

I didn't notice a change in behaviour/accuracy with this setup (3DR IRIS running a Pixhawk 4) which was performing OK before which is a good outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants