Increase uavcan main stack size #15864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed stack overflows when executing `uavcan params list`, so the stack size probably needs to be increased. Signed-off-by: Alex Mikhalev <alexmikhalevalex@gmail.com>
dagar
approved these changes
Oct 2, 2020
|
Thanks @amikhalev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
I observed hard faults when running
uavcan params list. A stackcheck build showed that theuavcantask overflowed its stack.Describe your solution
I increased the stack size for the
uavcancommandDescribe possible alternatives
None
Test data / coverage
Increasing stack size shouldn't cause any issues, but for what it's worth I have flown with this commit
https://review.px4.io/plot_app?log=d0f658d7-60ab-40ae-b4e2-a32aae84d942