Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commander: PreFlightCheck param_find all parameters immediately #15875

Merged
merged 1 commit into from
Oct 3, 2020
Merged

commander: PreFlightCheck param_find all parameters immediately #15875

merged 1 commit into from
Oct 3, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Oct 3, 2020 •
edited
Loading

@ryanjAA can you give this a try? If it resolves #15872 I can backport it for v1.11.1.

@dagar
commander: PreFlightCheck param_find all parameters immediately
fd5cb63 
 - this ensures the relevant parameters are marked active immediately
before parameter sync
 - fixes #15872
@dagar dagar added the bug label Oct 3, 2020
@dagar dagar requested a review from MaEtUgR October 3, 2020 15:29
@ryanjAA
Copy link
Contributor

ryanjAA commented Oct 3, 2020

Confirmed working (on Pixhawk 1). Soft and hard rebooted several times. Change airframe types, etc. Looks good.

COM_CPU_MAX is having the same problem (I didn't catch it until just now but is has always been omitted as well - apologies for that).

@dagar
Copy link
Member Author

dagar commented Oct 3, 2020

COM_CPU_MAX is having the same problem (I didn't catch it until just now but is has always been omitted as well - apologies for that).

That's weird, I don't see any special condition for finding COM_CPU_MAX. Do you see it if you search?

@dagar dagar merged commit eabbd19 into master Oct 3, 2020
@dagar dagar deleted the pr-commander_checks branch October 3, 2020 18:43
@ryanjAA
Copy link
Contributor

ryanjAA commented Oct 3, 2020

Nope. Don’t see it in search. Only when I force add it then it disappears after reboot. I’ll check again but I just ran into when testing this Pr.

@ryanjAA
Copy link
Contributor

ryanjAA commented Oct 3, 2020

Double checked - not there.

See this video, it shows what happens. Also tried setting an airframe and added in a reboot. Didn't change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaEtUgR MaEtUgR Awaiting requested review from MaEtUgR

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Parameters in 1.11
2 participants
@dagar @ryanjAA