Guard offboard and allow specifying the position setpoint type #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PX4_ISFINITE(set_position_target_local_ned.afy) && | ||
| PX4_ISFINITE(set_position_target_local_ned.afz) && | ||
| PX4_ISFINITE(set_position_target_local_ned.yaw); | ||
|
|
There was a problem hiding this comment.
I would argue that only the setpoints which are actually to be used (using the ignore mask) need to be finite.
There was a problem hiding this comment.
Well the others are going to be 0 if not set, if they are not finite something is wrong I'd say.
AndreasAntener
force-pushed
the
nan_guard_offboard
branch
from
58b6604
to
497751e
Compare
|
@julianoes if there is no other concern here I'll merge this |
AndreasAntener
force-pushed
the
nan_guard_offboard
branch
from
497751e
to
f3a1abf
Compare
|
Rebased and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses 2 things:
Later is the primary focus. This way we can use setpoint type specific functionality also in offboard (e.g. landing/takeoff). For mavros users this complements mavlink/mavros#402
handle_message_set_position_target_local_nedis field tested