Use the value of nuttx CONFIG_ARMV7M_STACKCHECK to configure PX4 build #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for HW stack checking
Closed
| @@ -523,6 +532,17 @@ function(px4_os_add_flags) | |||
|
|
|||
| set(added_exe_linker_flags) # none currently | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Good catch. I have no idea how that happened. It was definitely working in my branch, but I didn't test it after it went into master.
davids5
pushed a commit
that referenced
this pull request
May 20, 2016
…d for HW stack checking (#4572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is a register (R10) that must be preserved for the hardware stack checking to work. Both builds: Nuttx and the Flight code must be built with consistent instrumentation flags.
This PR use the value of CONFIG_ARMV7M_STACKCHECK from the board's defconfig to set the Flight code's instrumentation flags.