Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw_att_control delete dead code and minor cleanup #7855

Closed
wants to merge 6 commits into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 24, 2017

The FW coordinated turn parameters aren't used anymore so I deleted them in both the fw_att_control side and ecl. I also split the large single cpp file and named it to match the class.

ECL side: PX4/PX4-ECL#319

@dagar
Copy link
Member Author

dagar commented Aug 28, 2017

The only real change here is deleting the unused yaw coordination parameters, the rest is the single massive file, and trivial cleanup. @bresch @sanderux could you do a quick review?

@dagar
Copy link
Member Author

dagar commented Aug 30, 2017

TODO: readd ECL side PX4/PX4-ECL@b0300b9

@mrpollo
Copy link
Contributor

mrpollo commented Aug 30, 2017

please test @PX4TestFlights after @dagar rebase

@dagar
Copy link
Member Author

dagar commented Aug 30, 2017

Let's get #7773 in first, then I'll rebase.

@santiago3dr
Copy link

flight with a phantom flying wing running a pixhawk mini (V3)
https://logs.px4.io/plot_app?log=d5fafeac-9158-47b7-92c7-3e9d75a2f6f2
manual input non responsive in stabilized or altitude; rtl took a nose dive; had to retake manual control

compared to master on the same platform:
https://logs.px4.io/plot_app?log=3ba15b95-8a61-4f0f-a224-3539d706ed89

@dagar
Copy link
Member Author

dagar commented Aug 30, 2017

Thanks, will review the log in detail.
Did you build this branch yourself? The ecl commit is now gone so I'm wondering if something is was screwed up there. This was tested successfully in SITL.

@dagar dagar closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants