Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixedwing: implement TAS output scaling for FF #11975

Open
bresch opened this issue May 6, 2019 · 5 comments
Open

Fixedwing: implement TAS output scaling for FF #11975

bresch opened this issue May 6, 2019 · 5 comments

Comments

@bresch
Copy link
Member

bresch commented May 6, 2019

In the devguide (here) I demonstrated that the FF part of the rate controller has to be scaled linearly with true airspeed (TAS). At the moment, both PI quadratic scaling and FF linear scaling are done with indicated airspeed (IAS):
https://github.com/PX4/ecl/blob/c4492b17c1d7bb9b74011efa9890452b091421e8/attitude_fw/ecl_roll_controller.cpp#L111-L113

Since IAS depends on air density, this makes a real difference when flying at high altitudes, cold or warm places.

Note: I open this issue to remember that I still have to do that.

@bresch bresch self-assigned this May 6, 2019
@bresch bresch changed the title Fixedwing: implement IAS output scaling Fixedwing: implement TAS output scaling May 6, 2019
@bresch bresch changed the title Fixedwing: implement TAS output scaling Fixedwing: implement TAS output scaling for FF May 6, 2019
@stale
Copy link

stale bot commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Antiheavy
Copy link
Contributor

Agree, it makes sense to use TAS here. Although it would be nice to have better ways to estimate outside air temperature (OAT) in PX4. For example, our airspeed sensor heats up significantly in the cavity it is mounted in causing PX4 TAS estimate to be wrong. I've seen this handled in other systems by allowing a OAT offset parameter or also allowing different sources of OAT measurement, not just from the Diff Press sensor.

@stale
Copy link

stale bot commented Nov 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Nov 5, 2019
@supergra
Copy link
Contributor

supergra commented Jul 2, 2020

@Antiheavy Are you sure that the temperature is affecting your TAS measurement? Last time I checked the code, it seemed that PX4 just assumes the OAT is 20C and doesn't trust the temperature at all.

I agree with the need to compute TAS more accurately, but I don't think I've seen fluctuations in TAS even though the temperature measurements were wildly wrong.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants