Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

micrortps_bridge: uorb multi-topics don't work #8530

Closed
ChristophTobler opened this issue Dec 27, 2017 · 13 comments
Closed

micrortps_bridge: uorb multi-topics don't work #8530

ChristophTobler opened this issue Dec 27, 2017 · 13 comments

Comments

@ChristophTobler
Copy link
Contributor

ChristophTobler commented Dec 27, 2017

Currently, uorb multi-topics (e.g. optical_flow_raw, vehicle_vision_position, etc.) don't work with the micrortps_bridge.
https://github.com/PX4/Firmware/blob/master/src/modules/micrortps_bridge/CMakeLists.txt

related to #8495. But I guess we need to fix it anyways.

@dagar I saw you've worked on it. Is that something you could look into?

@dagar
Copy link
Member

dagar commented Dec 28, 2017

I'm not that familiar with FastRTPS itself, but at a glance it doesn't look like the concept of multi-topics exists. I think we'll need to treat them like individual topics (sensor_accel_0, sensor_accel_1, etc), but it could be done automatically.

The manually maintained message ids (https://github.com/PX4/Firmware/blob/master/msg/tools/uorb_rtps_message_ids.py#L5) are already a problem. So the entire thing needs to be considered.

Should we discuss this on the messaging working group call?

@ChristophTobler
Copy link
Contributor Author

Should we discuss this on the messaging working group call?

Sure. When's that?

@dagar
Copy link
Member

dagar commented Dec 29, 2017

It's on Thursday, although I've never attended.
https://dev.px4.io/en/contribute/#calendar

The big overall issue that's not at all clear to me is how we need to handle message versioning and ids when you start using them outside of Firmware.

@TSC21
Copy link
Member

TSC21 commented Aug 10, 2018

@santiago3dr can we please keep this open? This is something that still needs to be tackled.

@santiago3dr
Copy link

closing old issues, if they are being worked on or need to remain open, let's give them higher priority

@santiago3dr santiago3dr reopened this Aug 10, 2018
@TSC21
Copy link
Member

TSC21 commented Aug 10, 2018

Sure thing. I was actually unaware that this issue existed, but considering what I am working on now, makes sense to have it opened and solved asap.

@TSC21 TSC21 self-assigned this Aug 10, 2018
@stale
Copy link

stale bot commented Jan 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Feb 11, 2019

Closing as stale.

@stale stale bot closed this as completed Feb 11, 2019
@TSC21 TSC21 reopened this Feb 11, 2019
@stale stale bot removed the Admin: Wont fix label Feb 11, 2019
@dagar
Copy link
Member

dagar commented Feb 11, 2019

@TSC21 I believe you'll need to explicitly handle the instances as separate topics.

@TSC21
Copy link
Member

TSC21 commented Feb 11, 2019

@TSC21 I believe you'll need to explicitly handle the instances as separate topics.

Yes I know. Just didn't have time to implement this yet.

@TSC21
Copy link
Member

TSC21 commented Jun 2, 2019

Solution in #12137

@stale
Copy link

stale bot commented Aug 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@TSC21
Copy link
Member

TSC21 commented Aug 31, 2019

Solved already.

@TSC21 TSC21 closed this as completed Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants