Fix to allow filter correction with vision position estimate #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
LorenzMeier
added a commit
that referenced
this pull request
Jun 22, 2014
Fix to allow filter correction with vision position estimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tested the vision_estimate branch with sending vision_position_estimate mavlink messages I noticed the returned local_position_ned position wasn't the same. It appears it wasn't doing the filter correction.
This is my first pull request so hopefully I am doing it correctly.
Also I guess the vision code added #1041 was just a quick hack to get the vision_position_estimate to work and will probably need to be written with its own bool use_vision_xy etc.?