Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mag current/throttle compensation #14457

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Mag current/throttle compensation #14457

merged 3 commits into from
Mar 26, 2020

Conversation

baumanta
Copy link
Contributor

New feature to compensate compass for current/throttle:
Parameters for each axis have to be identified offline using the provided python script. If there is no current reading available, there is the option to compensate for thrust, only advisable if the relationship is linear for the given setup (In my tests I've observed that for some setups the relationship is linear and it works well, for others it is not).

Offline parameter identification:
Screenshot from 2020-03-23 11-20-10
Screenshot from 2020-03-23 11-20-31

Log from drone with parameters for current compensation applied:
https://logs.px4.io/plot_app?log=cf3ca047-ea1b-43c0-b8dd-a425bea539d4
Screenshot from 2020-03-23 11-25-24

@baumanta
Copy link
Contributor Author

Documentation has started as well: PX4/PX4-user_guide#692

@xdwgood
Copy link
Contributor

xdwgood commented Mar 24, 2020

This solves the effect of the current generated by the thrust change on the geomagnetic sensor due to the improper layout of the circuit board.Right? 😃

RomanBapst
RomanBapst previously approved these changes Mar 24, 2020
RomanBapst
RomanBapst previously approved these changes Mar 24, 2020
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we can still add to the release. Any objections?

@bkueng bkueng merged commit 2103b8f into master Mar 26, 2020
@bkueng bkueng deleted the mag_comp_upstream branch March 26, 2020 07:00
@mrpollo mrpollo mentioned this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants