PX4 · dagar · Sep 17, 2020 · Jun 17, 2020 · Jun 17, 2020 · Jun 17, 2020
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -30,7 +30,7 @@ jobs:
           #bionic,
           focal
           ]
-    container: px4io/px4-dev-nuttx-${{ matrix.ubuntu_release }}:2020-04-01
+    container: px4io/px4-dev-nuttx-${{ matrix.ubuntu_release }}:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:

diff --git a/.github/workflows/clang-tidy.yml b/.github/workflows/clang-tidy.yml
@@ -11,7 +11,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-clang:2020-04-01
+    container: px4io/px4-dev-clang:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:

diff --git a/.github/workflows/compile_linux.yml b/.github/workflows/compile_linux.yml
@@ -11,7 +11,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-armhf:2020-04-01
+    container: px4io/px4-dev-armhf:2020-08-14
     strategy:
       matrix:
         config: [

diff --git a/.github/workflows/compile_nuttx.yml b/.github/workflows/compile_nuttx.yml
@@ -11,7 +11,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-nuttx-bionic:2020-04-01
+    container: px4io/px4-dev-nuttx-bionic:2020-08-14
     strategy:
       matrix:
         config: [

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -11,7 +11,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-base-focal:2020-04-01
+    container: px4io/px4-dev-base-focal:2020-08-14
     strategy:
       matrix:
         config: [

diff --git a/.github/workflows/mavros_avoidance_tests.yml b/.github/workflows/mavros_avoidance_tests.yml
@@ -19,7 +19,7 @@ jobs:
           - {test_file: "mavros_posix_test_safe_landing.test", vehicle: "iris_obs_avoid", mission: "MC_safe_landing", build_type: "RelWithDebInfo"}
 
     container:
-      image: px4io/px4-dev-ros-melodic:2020-04-01
+      image: px4io/px4-dev-ros-melodic:2020-08-14
       options: --privileged --ulimit core=-1 --security-opt seccomp=unconfined
     steps:
     - uses: actions/checkout@v1

diff --git a/.github/workflows/mavros_mission_tests.yml b/.github/workflows/mavros_mission_tests.yml
@@ -25,7 +25,7 @@ jobs:
           - {vehicle: "tiltrotor",     mission: "VTOL_mission_1",  build_type: "RelWithDebInfo"}
 
     container:
-      image: px4io/px4-dev-ros-melodic:2020-04-01
+      image: px4io/px4-dev-ros-melodic:2020-08-14
       options: --privileged --ulimit core=-1 --security-opt seccomp=unconfined
     steps:
     - uses: actions/checkout@v1

diff --git a/.github/workflows/mavros_offboard_tests.yml b/.github/workflows/mavros_offboard_tests.yml
@@ -20,7 +20,7 @@ jobs:
           #- {test_file: "mavros_posix_tests_offboard_rpyrt_ctl.test", vehicle: "iris", build_type: "RelWithDebInfo"}
 
     container:
-      image: px4io/px4-dev-ros-melodic:2020-04-01
+      image: px4io/px4-dev-ros-melodic:2020-08-14
       options: --privileged --ulimit core=-1 --security-opt seccomp=unconfined
     steps:
     - uses: actions/checkout@v1

diff --git a/.github/workflows/metadata.yml b/.github/workflows/metadata.yml
@@ -12,7 +12,7 @@ jobs:
 
   airframe:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-base-focal:2020-04-01
+    container: px4io/px4-dev-base-focal:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:
@@ -27,7 +27,7 @@ jobs:
 
   module:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-base-focal:2020-04-01
+    container: px4io/px4-dev-base-focal:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:
@@ -42,7 +42,7 @@ jobs:
 
   parameter:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-base-focal:2020-04-01
+    container: px4io/px4-dev-base-focal:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:
@@ -57,7 +57,7 @@ jobs:
 
   uorb_graph:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-nuttx-focal:2020-04-01
+    container: px4io/px4-dev-nuttx-focal:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:
@@ -86,7 +86,7 @@ jobs:
 
   ROS_msgs:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-base-bionic:2020-04-01
+    container: px4io/px4-dev-base-bionic:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:
@@ -99,7 +99,7 @@ jobs:
 
   ROS2_bridge:
     runs-on: ubuntu-latest
-    container: px4io/px4-dev-base-bionic:2020-04-01
+    container: px4io/px4-dev-base-bionic:2020-08-14
     steps:
     - uses: actions/checkout@v1
       with:

diff --git a/.github/workflows/sitl_tests.yml b/.github/workflows/sitl_tests.yml
@@ -20,7 +20,7 @@ jobs:
           - {latitude:  "29.660316", longitude:  "-82.316658", altitude:  "30", build_type: "RelWithDebInfo"} # Florida
           - {latitude:  "47.397742", longitude:    "8.545594", altitude: "488", build_type: "Coverage"} # Zurich
     container:
-      image: px4io/px4-dev-simulation-focal:2020-04-01
+      image: px4io/px4-dev-simulation-focal:2020-08-14
       options: --privileged --ulimit core=-1 --security-opt seccomp=unconfined
     steps:
     - uses: actions/checkout@v1

diff --git a/ROMFS/CMakeLists.txt b/ROMFS/CMakeLists.txt
@@ -271,11 +271,15 @@ if(SHELLCHECK_PATH)
 	# TODO: fix SC2086, SC2166
 	add_custom_target(shellcheck
 		COMMAND ${SHELLCHECK_PATH} --shell=sh
+			--exclude=SC1090 # SC1090: use of source (.) - Can't follow non-constant source. Use a directive to specify location.
+			--exclude=SC1091 # SC1091: use of source (.) - Not following: xxxx openBinaryFile: does not exist (No such file or directory)
 			--exclude=SC2121 # SC2121: To assign a variable, use just 'var=value'
 			--exclude=SC2086 # SC2086: Double quote to prevent globbing and word splitting.
 			--exclude=SC2166 # SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
 			--exclude=SC2154 # SC2154: <var> is referenced but not assigned (NuttX uses different asssignment)
 			--exclude=SC2164 # SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
+			--exclude=SC2169 # SC2169: In dash, 'source' in place of '.' is not supported. (we alias it)
+			--exclude=SC2039 # SC2039: In POSIX sh, 'source' in place of '.' is undefined. (we alias it)
 			--exclude=SC2181 # SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
 			`find ${romfs_gen_root_dir}/init.d -type f`
 		DEPENDS ${romfs_gen_root_dir}/init.d/rc.autostart

diff --git a/ROMFS/cannode/init.d/rcS b/ROMFS/cannode/init.d/rcS
@@ -61,7 +61,7 @@ set BOARD_RC_DEFAULTS /etc/init.d/rc.board_defaults
 if [ -f $BOARD_RC_DEFAULTS ]
 then
 	echo "Board defaults: ${BOARD_RC_DEFAULTS}"
-	sh $BOARD_RC_DEFAULTS
+	. $BOARD_RC_DEFAULTS
 fi
 unset BOARD_RC_DEFAULTS
 
@@ -87,15 +87,15 @@ set BOARD_RC_SENSORS /etc/init.d/rc.board_sensors
 if [ -f $BOARD_RC_SENSORS ]
 then
 	echo "Board sensors: ${BOARD_RC_SENSORS}"
-	sh $BOARD_RC_SENSORS
+	. $BOARD_RC_SENSORS
 fi
 unset BOARD_RC_SENSORS
 
 #
 # Start UART/Serial device drivers.
 # Note: rc.serial is auto-generated from Tools/serial/generate_config.py
 #
-sh /etc/init.d/rc.serial
+. /etc/init.d/rc.serial
 
 # Check for flow sensor
 if param compare SENS_EN_PX4FLOW 1

diff --git a/ROMFS/px4fmu_common/init.d/airframes/1000_rc_fw_easystar.hil b/ROMFS/px4fmu_common/init.d/airframes/1000_rc_fw_easystar.hil
@@ -15,7 +15,7 @@
 # @maintainer Lorenz Meier <lorenz@px4.io>
 #
 
-sh /etc/init.d/rc.fw_defaults
+. /etc/init.d/rc.fw_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/10015_tbs_discovery b/ROMFS/px4fmu_common/init.d/airframes/10015_tbs_discovery
@@ -23,7 +23,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/10016_3dr_iris b/ROMFS/px4fmu_common/init.d/airframes/10016_3dr_iris
@@ -21,7 +21,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/10017_steadidrone_qu4d b/ROMFS/px4fmu_common/init.d/airframes/10017_steadidrone_qu4d
@@ -23,7 +23,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/10018_tbs_endurance b/ROMFS/px4fmu_common/init.d/airframes/10018_tbs_endurance
@@ -23,7 +23,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/1001_rc_quad_x.hil b/ROMFS/px4fmu_common/init.d/airframes/1001_rc_quad_x.hil
@@ -8,7 +8,7 @@
 # @maintainer Lorenz Meier <lorenz@px4.io>
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 set MIXER quad_x
 set PWM_OUT 1234

diff --git a/ROMFS/px4fmu_common/init.d/airframes/1002_standard_vtol.hil b/ROMFS/px4fmu_common/init.d/airframes/1002_standard_vtol.hil
@@ -8,7 +8,7 @@
 # @maintainer Roman Bapst <roman@auterion.com>
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/11001_hexa_cox b/ROMFS/px4fmu_common/init.d/airframes/11001_hexa_cox
@@ -22,7 +22,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 set MIXER hexa_cox
 

diff --git a/ROMFS/px4fmu_common/init.d/airframes/1100_rc_quad_x_sih.hil b/ROMFS/px4fmu_common/init.d/airframes/1100_rc_quad_x_sih.hil
@@ -8,7 +8,7 @@
 # @maintainer Romain Chiappinelli <romain.chiap@gmail.com>
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 set MIXER quad_x
 set PWM_OUT 1234

diff --git a/ROMFS/px4fmu_common/init.d/airframes/12001_octo_cox b/ROMFS/px4fmu_common/init.d/airframes/12001_octo_cox
@@ -20,7 +20,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 set MIXER octo_cox
 

diff --git a/ROMFS/px4fmu_common/init.d/airframes/12002_steadidrone_mavrik b/ROMFS/px4fmu_common/init.d/airframes/12002_steadidrone_mavrik
@@ -20,7 +20,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.mc_defaults
+. /etc/init.d/rc.mc_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13000_generic_vtol_standard b/ROMFS/px4fmu_common/init.d/airframes/13000_generic_vtol_standard
@@ -18,7 +18,7 @@
 # @output AUX5 Throttle
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13001_caipirinha_vtol b/ROMFS/px4fmu_common/init.d/airframes/13001_caipirinha_vtol
@@ -13,7 +13,7 @@
 # @maintainer Roman Bapst <roman@px4.io>
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13002_firefly6 b/ROMFS/px4fmu_common/init.d/airframes/13002_firefly6
@@ -22,7 +22,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13003_quad_tailsitter b/ROMFS/px4fmu_common/init.d/airframes/13003_quad_tailsitter
@@ -8,7 +8,7 @@
 # @maintainer Roman Bapst <roman@px4.io>
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13004_quad+_tailsitter b/ROMFS/px4fmu_common/init.d/airframes/13004_quad+_tailsitter
@@ -21,7 +21,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13005_vtol_AAERT_quad b/ROMFS/px4fmu_common/init.d/airframes/13005_vtol_AAERT_quad
@@ -21,7 +21,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13006_vtol_standard_delta b/ROMFS/px4fmu_common/init.d/airframes/13006_vtol_standard_delta
@@ -19,7 +19,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13007_vtol_AAVVT_quad b/ROMFS/px4fmu_common/init.d/airframes/13007_vtol_AAVVT_quad
@@ -11,7 +11,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13008_QuadRanger b/ROMFS/px4fmu_common/init.d/airframes/13008_QuadRanger
@@ -11,7 +11,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13009_vtol_spt_ranger b/ROMFS/px4fmu_common/init.d/airframes/13009_vtol_spt_ranger
@@ -11,7 +11,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13010_claire b/ROMFS/px4fmu_common/init.d/airframes/13010_claire
@@ -12,7 +12,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13012_convergence b/ROMFS/px4fmu_common/init.d/airframes/13012_convergence
@@ -20,7 +20,7 @@
 # @board bitcraze_crazyflie exclude
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then

diff --git a/ROMFS/px4fmu_common/init.d/airframes/13013_deltaquad b/ROMFS/px4fmu_common/init.d/airframes/13013_deltaquad
@@ -17,7 +17,7 @@
 # @output MAIN8 Pusher reverse channel
 #
 
-sh /etc/init.d/rc.vtol_defaults
+. /etc/init.d/rc.vtol_defaults
 
 if [ $AUTOCNF = yes ]
 then