Fix template_module header #17960
Merged
Fix template_module header #17960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SubscriptionInterval.hpp includes Subscription.hpp, but not vice versa - The time literal 1_s is defined in the namespace time_literals
dagar
approved these changes
Jul 21, 2021
|
We should probably be building this to keep it alive. Similar to |
|
Thanks for merging. Yeah that would make sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not tried compiling the template module itself, but when using it as a template, the following where the additions that I had to make in order for it to compile.
1_sis defined in the namespace time_literals