Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataman: add SYS_DM_BACKEND parameter #18827

Merged
merged 2 commits into from Dec 10, 2021
Merged

dataman: add SYS_DM_BACKEND parameter #18827

merged 2 commits into from Dec 10, 2021

Conversation

dagar
Copy link
Member

@dagar dagar commented Dec 9, 2021

  • new parameter SYS_DM_BACKEND to configure dataman to use the SD file backend (default) or RAM
  • reduce NUM_MISSIONS_SUPPORTED from 2000->500 so RAM backend is viable on typical F7

@dagar dagar requested a review from julianoes December 9, 2021 17:52
@dagar
Copy link
Member Author

dagar commented Dec 9, 2021

Do we want to think about a realistic max for NUM_MISSIONS_SUPPORTED while we're on the subject?

@dagar dagar force-pushed the pr-dataman_storage branch 3 times, most recently from e9866aa to 7e703cf Compare December 9, 2021 18:02
@@ -49,7 +49,7 @@
#elif defined(__PX4_POSIX)
# define NUM_MISSIONS_SUPPORTED (UINT16_MAX-1) // This is allocated as needed.
#else
# define NUM_MISSIONS_SUPPORTED 2000 // This allocates a file of around 181 kB on the SD card.
# define NUM_MISSIONS_SUPPORTED 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok although note that a MAVSDK mission with 100 waypoints easily requires 500 mavlink mission items as it expands more complex mission items into several mavlink mission items.

Copy link
Member Author

@dagar dagar Dec 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let me know if it becomes an issue and we could find a way to make it more configurable or dynamic (at init).

@dagar dagar merged commit d961a06 into master Dec 10, 2021
@dagar dagar deleted the pr-dataman_storage branch December 10, 2021 14:10
@ryanjAA
Copy link
Contributor

ryanjAA commented Dec 12, 2021

Will Mission items include camera photo mav messages during a survey? Because if so a moderate survey would be greater than 500.

@dagar
Copy link
Member Author

dagar commented Dec 13, 2021

Will Mission items include camera photo mav messages during a survey? Because if so a moderate survey would be greater than 500.

It includes all mavlink mission items. Do you have a particular number in mind?

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/what-is-the-practical-limit-to-the-number-of-waypoints-mission-items-for-px4/2747/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants