syscmds/param: For -a flag (show all), show also the unused parameters #20529
Conversation
- This was causing some confusion, when the PX4 code wansn't using a specific param during runtime, and a user was unable to view the value using the `param show` command, since there was no way to enable viewing unused params, if they were unchanged - This now enables to show the unused params when the systemcmd is provoked with the -a flag, as that makes sense - Also, it adds a note in the param_show function if we print out only used params, that we are in fact only printing out only 'used' params! (This will hopefully reduce the confusion among users)
| { | ||
| if (only_used) { | ||
| PARAM_PRINT("Warning! Only parameters used during runtime will be shown\n"); |
There was a problem hiding this comment.
A note should be enough.
| PARAM_PRINT("Warning! Only parameters used during runtime will be shown\n"); | |
| PARAM_PRINT("Note: only parameters used during runtime will be shown\n"); |
I would be a bit careful here, for all intents and purposes these parameters don't exist (to users). |
Right, but we currently don't have any way to manipulate parameters that are not used in run-time, and having a |
What do you think about then preserving the That would enable user to have full access to parameter ( |
Describe problem solved by this pull request
PX4 by default was not showing the 'unused' parameters (e.g. Rover control parameters, when running quadcopter modules) that were not provoked / read / set by any module through the
paramsystemcmd interface, unless we were showing the 'non-default' parameter values.This creates a confusion to the user who isn't aware of this
paramsystemcmd behavior, to think that the parameter doesn't exist (as it can't be found with theparam show <NAME>command, but in fact it is only not being shown because we have been specifying to only show the 'used' parameters.Describe your solution
-aflag (which was not possible before)usedparameters, to inform the userparam show <PARAM_NAME>command, with no flags (makes sense, as long as we have a warning to the user that we are only showing the subset)Test data / coverage
Before the change
After the change
Additional context
@potaito this should solve your mystery 😉