tunes: Pause alarm delimiters in tune_control #20541
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junwoo091400
requested changes
Nov 17, 2022
Comment on lines
+95
to
+96
| PX4_DEFINE_TUNE(7, BATTERY_WARNING_SLOW, "MBT100a8P", true /* battery warning slow */) | ||
| PX4_DEFINE_TUNE(8, BATTERY_WARNING_FAST, "MBT255a8a8a8a8a8a8a8a8a8a8a8a8a8a8a8a8P", true /* battery warning fast */) |
There was a problem hiding this comment.
Seems like the definition requires a number in the range of 1 ~ 64 for the duration of pause: http://www.vgmpf.com/Wiki/index.php?title=Microsoft_BASIC_MML
Any reason you didn't specify the definition?
There was a problem hiding this comment.
@junwoo091400 san. I have matched it to ERROR_TUNE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
The tune_control command set off a standard PX4 alarm.
https://github.com/PX4/PX4-Autopilot/blob/main/src/lib/tunes/tune_definition.desc#L95
https://github.com/PX4/PX4-Autopilot/blob/main/src/lib/tunes/tune_definition.desc#L96
After two alarms were executed, it hung.
This phenomenon occurs in HOLYBLO PIXHARK 5x and 6C. Other FCs are unknown.
Describe your solution
In the alarm pattern, N is specified as the alarm delimiter.
When this N was removed, it could be executed many times. However, the alarm delimiter is lost.
N and P are alarm delimiter designations.
I change N to P.
Describe possible alternatives
None.
Test data / coverage
I ran this many times with QGC's MAVLINK CONSOLE.
Additional context
none