Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: restart on file write error #21389

Merged
merged 1 commit into from Jun 8, 2023
Merged

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Mar 29, 2023

This can also happen if the maximum file size is reached.

This can also happen if the maximum file size is reached.
@bkueng bkueng force-pushed the logger_restart_on_file_error branch from d221224 to e95fdbe Compare June 7, 2023 07:38
@tstastny tstastny requested review from dagar and ThomasDebrunner and removed request for dagar June 7, 2023 08:42
@bkueng bkueng merged commit f119cca into main Jun 8, 2023
83 of 87 checks passed
@bkueng bkueng deleted the logger_restart_on_file_error branch June 8, 2023 07:52
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/ulg-file-maximum-size/29081/6

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/how-does-people-deal-with-large-ulog-file/32918/10

@lvanasse
Copy link

lvanasse commented Nov 3, 2023

Hi @bkueng ! I started testing this PR yesterday, and I've let my PX4 ran all night and this morning when I checked the log, I didn't have any. Which was the behaviour before testing with this PR.

I assume you've tested it, but I was wondering if you've done long endurance test like I did?

@bkueng
Copy link
Member Author

bkueng commented Nov 6, 2023

Yes I tested the error case, but not specifically an endurance test. Do you happen to have the console output (or dmesg)?

@lvanasse
Copy link

lvanasse commented Nov 6, 2023

You mean console out or dmesg of when the logger module fails? If that's the case, it's a bit hard to catch since, the bug happens only after maybe a couple of hours (3-5 hours). I was testing a custom module, and had it in verbose more, so it was logging a lot, but now with the logger stopping to log I'll try to reduce as much as possible the logging in the console output and replace it with the logger instead.

I'll try to have something by the end of the day.

@lvanasse
Copy link

lvanasse commented Nov 7, 2023

@bkueng sadly, after 5 hours, the logger stopped logging, and I didn't see anything in the dmesg. I'll turn on the DBGPRINT in the logger module and restart the test. Also, maybe it's an issue where the SD card is full and just can't log anymore. But if that's the case, there should be an error message coming from the logger module.

@lvanasse
Copy link

lvanasse commented Nov 7, 2023

I spoke too fast, I don't think there's a way for the DBGPRINT to be enabled in the module. There's error with the struct mallinfo because it's from POSIX, but doesn't seem to be present in NuttX

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-community-q-a-november-08-2023/35087/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants