Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavlink receiver unadvertise all uorb multi topics #21631

Merged
merged 1 commit into from May 24, 2023

Conversation

AlexKlimaj
Copy link
Member

When a mavlink stream is closed, the uorb multi pubs need to be unadvertised. Otherwise when the stream comes back, a second instance can be created in uorb.

@AlexKlimaj AlexKlimaj requested a review from dagar May 23, 2023 16:39
@dagar
Copy link
Member

dagar commented May 23, 2023

Looks good, but you caught a bunch of submodule changes in the commit.

uorb multi pubs in destructor
@AlexKlimaj AlexKlimaj force-pushed the pr-mavlink-uorb-unadvertise branch from ebb4a77 to 256c688 Compare May 23, 2023 21:15
@dagar dagar merged commit dc99a87 into PX4:main May 24, 2023
81 of 85 checks passed
@AlexKlimaj AlexKlimaj deleted the pr-mavlink-uorb-unadvertise branch May 24, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants