Cannode add Gnss Auxiliary publisher #21637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexKlimaj
force-pushed
the
pr-cannode-gps-aux
branch
from
db91355
to
eb06fba
Compare
AlexKlimaj
force-pushed
the
pr-cannode-gps-aux
branch
from
eb06fba
to
b6013b3
Compare
dagar
reviewed
May 24, 2023
dagar
reviewed
May 24, 2023
| if (uORB::SubscriptionCallbackWorkItem::update(&gps)) { | ||
| uavcan::equipment::gnss::Auxiliary auxiliary{}; | ||
|
|
||
| //auxiliary.gdop = gps.gdop; |
There was a problem hiding this comment.
Ideally we'd have a mechanism to explicitly say these aren't available.
dagar
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a gnss auxiliary publisher to the cannode in order to transmit the actual hdop and vdop instead of relying on pdop.