nsh: check nsh_consolemain return value #22012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDebrunner
previously approved these changes
Aug 28, 2023
|
I pushed a fix for the trivial astyle whitespace failure. https://github.com/PX4/PX4-Autopilot/actions/runs/5998073699/job/16265657710?pr=22012
|
niklaut
force-pushed
the
pr-nsh_consolemain-enomem
branch
from
be77f94
to
e6a495c
Compare
Starting a new console allocates memory dynamically, which can fail.
niklaut
force-pushed
the
pr-nsh_consolemain-enomem
branch
from
e6a495c
to
7ee702b
Compare
dagar
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Starting a new console allocates memory dynamically, which can fail, but the pointer wasn't checked and caused a hardfault on heap exhaustion.
This adds the check and returns a error message if the console fails to allocate.
For details on the hardfault see: PX4/NuttX-apps#18
Changelog Entry
For release notes:
Test coverage
Tested manually via GDB by forcing zalloc to return NULL for the test case. Reproduces the crash reliably.
Context
Now AMC reports this on failure, instead of hardfaulting.
I will check if there are more cases of malloc not getting handled, however, this is an important fix already.