Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake/kconfig.cmake: Don't populate config_kernel_list in nuttx flat … #22063

Merged

Conversation

jlaitine
Copy link
Contributor

@jlaitine jlaitine commented Sep 8, 2023

…builds

This passes KERNEL compilation flag to all modules, which may break some NuttX headers

…builds

This passes __KERNEL__ compilation flag to all modules, which may break some NuttX headers

Signed-off-by: Jukka Laitinen <jukkax@ssrc.tii.ae>
@dagar
Copy link
Member

dagar commented Sep 8, 2023

FYI @julianoes

@jlaitine jlaitine marked this pull request as ready for review September 12, 2023 11:18
@jlaitine
Copy link
Contributor Author

jlaitine commented Sep 12, 2023

@dagar @julianoes This is good on my behalf, feel free to merge if you like. Or close if the change is merged together with the #22047

@julianoes julianoes merged commit 9bcfd1a into PX4:main Sep 13, 2023
85 of 86 checks passed
@jlaitine jlaitine deleted the dont_populate_config_kernel_list_in_flat_builds branch December 1, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants