-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add windy default world #22273
add windy default world #22273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Three questions
- Is this already part of the available make targets?
- Have you tried out vehicles in wind and checked if they actually influence the flight? Wind should influence the thrust of the motors, lift/drag of aerodynamics and the airspeed sensor values
- Probably worth checking if the advanced liftdrag plugin also uses wind information?
|
If so, how is someone expected to run the windy world? Could you include this in the PR description?
I am more curious the actual behavior -> whether if it is close to what we expect on the real vehicle, or if it is just applying some wrench force on the joints to look like some force is being applied. Do you have a flight log from the tests? It would be great if you could keep the PR template and fill in the relevant information, so that we don't need to go back and forth. Please also check with the airspeed sensors and liftdrag plugins.
Awesome! |
Updated the description to explain how to run the world and also provided a flightreview. I am not sure how to interpret the data to see whether the model behaves as we want it to. |
The way I understand wind, it can be enabled for individual links or the whole model, depending on what parameters are set. By only setting the |
Thanks @frede791 ! make px4_sitl gz_x500_windy_default |
@beniaminopozzan i have tried this but I get an "unknown target" error |
@frede791 , do a clean build calling |
yes this works. I will update the PR and also make a PR to the px4 user guide. |
@frede791 One more thing -> could we remove the default and just name in |
@Jaeyoung-Lim @beniaminopozzan Addition to the PX4 user guide. Feel free to add if you think there is something missing/lacking. |
@Jaeyoung-Lim PX4/PX4-user_guide#2817 has been merged into the user guide. Should we look to merge this as well? |
Adds a windy default world to Gazebo. Changing the wind velocity only requires to modify the
linear_velocity
parameter near the bottom of the sdf file.To run the world use:
make px4_sitl gz_x500_windy
in the PX4-Autopilot repo. You may run into anunknown target
error. In this case first runmake clean && make distclean
before running the command.Solved Problem
Adds a windy default world to Gazebo. Changing the wind velocity only requires to modify the
linear_velocity
parameter near the bottom of the sdf file.Test coverage
https://review.px4.io/plot_app?log=b0969110-5339-4e60-8c22-30bb36020d4b