fixing the turning direction of the Cessna Propeller #22276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: frederik <frederik@auterion.com>
|
@Jaeyoung-Lim Anything that needs to be added here? |
Jaeyoung-Lim
approved these changes
Nov 9, 2023
frede791
added a commit
to frede791/PX4-Autopilot
that referenced
this pull request
Nov 14, 2023
Signed-off-by: frederik <frederik@auterion.com> Co-authored-by: frederik <frederik@auterion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
The Cessna Propeller has a mismatch between the turning direction and the propeller used. This PR fixes this so that the propeller direction is the same as in real Cessnas and also matches the correct propeller mesh. This PR does not fix the ugly the visual bug that is encountered in the
iris_prop_cw.daemesh when it is viewed from the rear.Fixes #22275
Solution
Change the
<turningDirection>parameter fromcwtoccw.