Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mavlink: Handle NAMED_VALUE_INT #22525

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

sverrevr
Copy link
Contributor

Implements mavlink NAMED_VALUE_INT

Test coverage

  • Tested in flight

Copy link
Member

@dagar dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I see the value in this, but I suppose it's fine.

We may need to add an option to disable this later (both build time and runtime).

debug_topic.timestamp = hrt_absolute_time();
memcpy(debug_topic.key, debug_msg.name, sizeof(debug_topic.key));
debug_topic.key[sizeof(debug_topic.key) - 1] = '\0'; // enforce null termination
debug_topic.value = debug_msg.value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this is a 32 bit float and can't hold every value of this integer.

@dagar dagar merged commit 91e3ec5 into PX4:main Dec 13, 2023
86 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants