Fix Figure Eight CI Test #22529
Merged
Fix Figure Eight CI Test #22529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_until_altitude() checks for absolute altitude being close so checking for 1m below the setpoint can fail if the speedup results in no sample inside the altitude window being checked. Ideally the test could check if the takeoff is done directly instead of comparing altitudes in the first place.
|
Happy CI 🎉 |
|
Thanks a lot was driving me nuts as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When working on PRs I was going nuts about the figure eight test failing more often than not.
Solution
wait_until_altitude() checks for absolute altitude being close so checking for 1m below the setpoint can fail if the speedup results in no sample inside the altitude window being checked.
Changelog Entry
Alternatives
Ideally the test could check if the takeoff is done directly instead of comparing altitudes in the first place.
Test coverage
I successfully ran the test 100 times with the altitude thershold 5 times narrower at 10cm instead of 50cm. Without the fix I had it fail locally basically every single time.
