Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MissionFeasibilityChecker: remove below home check #22624

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Jan 11, 2024

This check gave a warning when one or more mission items were below the Home altitude. As it is a valid use case to plan missions below Home, those warnings were too often seen as a inconvenience and are thus removed here.

Changelog Entry

For release notes:

Feature: MissionFeasibilityChecker: remove below home check

fyi @cmic0

This check gave a warning when one or more mission items were below the
Home altitude. As it is a valid usecase to plan missions below Home,
those warnings were too often seen as a inconvenience and are thus
removed here.

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@sfuhrer sfuhrer requested a review from MaEtUgR January 11, 2024 10:34
Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know this exists. I'm not a big fan since if there is an actual use case it's probably annoying.

@sfuhrer sfuhrer merged commit 1299702 into main Jan 12, 2024
89 of 90 checks passed
@sfuhrer sfuhrer deleted the pr-feasibility-check-remove-warning-below-home-main branch January 12, 2024 08:53
somebody-once-told-me pushed a commit to somebody-once-told-me/PX4-Autopilot that referenced this pull request Jan 13, 2024
This check gave a warning when one or more mission items were below the
Home altitude. As it is a valid usecase to plan missions below Home,
those warnings were too often seen as a inconvenience and are thus
removed here.

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Peize-Liu pushed a commit to Peize-Liu/PX4-Autopilot that referenced this pull request Mar 24, 2024
This check gave a warning when one or more mission items were below the
Home altitude. As it is a valid usecase to plan missions below Home,
those warnings were too often seen as a inconvenience and are thus
removed here.

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants